Skip to content

Conversation

sreeisalso
Copy link
Contributor

What is it?

  • Infra

Description

updated syncpack to v14, due to #7581

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

Copy link

changeset-bot bot commented May 13, 2025

⚠️ No Changeset found

Latest commit: c1fe498

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sreeisalso
Copy link
Contributor Author

sreeisalso commented May 13, 2025

in all the version after 12.3.3 upto 13.0.4, there is some error in syncpack format

@sreeisalso sreeisalso marked this pull request as ready for review May 13, 2025 09:12
@sreeisalso sreeisalso requested review from a team as code owners May 13, 2025 09:12
Copy link
Contributor

github-actions bot commented May 13, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview c1fe498

@JamieMason
Copy link

Thanks for trying v14, just a note to be careful as it's still in alpha - any problems let me know and I can try to help.

@sreeisalso
Copy link
Contributor Author

Thanks for trying v14, just a note to be careful as it's still in alpha - any problems let me know and I can try to help.

How to use config file?

Copy link

pkg-pr-new bot commented May 15, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7587
npm i https://pkg.pr.new/@builder.io/qwik-city@7587
npm i https://pkg.pr.new/eslint-plugin-qwik@7587
npm i https://pkg.pr.new/create-qwik@7587

commit: c1fe498

@JamieMason
Copy link

JamieMason commented May 15, 2025

Thanks for trying v14, just a note to be careful as it's still in alpha - any problems let me know and I can try to help.

How to use config file?

Create a .syncpackrc.json in the root of the project. I'm writing new docs at the moment but the current ones are here

{
  "$schema": "https://unpkg.com/[email protected]/schema.json"
  // your config here
}

EDIT: If you need them the docs have since been updated for v14 https://jamiemason.github.io/syncpack

@sreeisalso sreeisalso requested a review from wmertens May 15, 2025 12:18
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm that the syntax works, or adjust?

"dependencies": [
"eslint"
],
"pinVersion": "^8.57.0 || ^9.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this syntax doesn't work, for vite we had to do >=5 <8 instead of 5||6||7

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok,I didn't have the bandwidth to test those, closing this and creating a new PR with minimal changes

@sreeisalso sreeisalso mentioned this pull request Aug 20, 2025
5 tasks
@sreeisalso
Copy link
Contributor Author

Closing this PR in favor of #7844

@sreeisalso sreeisalso closed this Aug 20, 2025
@sreeisalso sreeisalso deleted the syncpack-update branch August 20, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants